This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
add parameters from schema top level as expected params #79
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Params within definitions but not inside one of the definitionsThis one is non-valid JSON schema. It would be parsed as a definition group called I don't think that we need to consider this scenario? Just within definitions (as already done) and in the top level. |
ewels
approved these changes
Aug 18, 2023
Comment on lines
290
to
295
| // Collect expected parameters from the schema when parameters are specified within "definitions" | ||
| if (schemaParams.containsKey('properties')) { | ||
| def enumsTupleDefinitions = collectEnums(['definitions': ['properties': schemaParams.get('properties')]]) | ||
| expectedParams += (List) enumsTupleDefinitions[0] | ||
| enums += (Map) enumsTupleDefinitions[1] | ||
| } |
There was a problem hiding this comment.
I don't think that we need this one..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters defined in the schema top level or within
definitionsare consideredexpectedParams.{ "$schema": "http://json-schema.org/draft-07/schema", "type": "object", // Top level params "properties": { "test_param_1": { "type": "string" } }, // Definition groups "definitions": { "my_group_of_params": { "title": "A virtual grouping used for docs and pretty-printing", "type": "object", "required": ["foo", "bar"], "properties": { "foo": { "type": "string" }, "bar": { "type": "string" } } }, // Params within definitions but not inside one of the definitions "properties": { "test_param_2": { "type": "string" } } }, // Contents of each definition group brought into main schema for validation "allOf": [ { "$ref": "#/definitions/my_group_of_params" } , { "$ref": "#/definitions" } ] }